Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7EF65200BA3 for ; Fri, 9 Sep 2016 02:36:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7DC32160AAD; Fri, 9 Sep 2016 00:36:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F1470160AD1 for ; Fri, 9 Sep 2016 02:36:21 +0200 (CEST) Received: (qmail 12189 invoked by uid 500); 9 Sep 2016 00:36:21 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 12005 invoked by uid 99); 9 Sep 2016 00:36:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Sep 2016 00:36:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id AC4B92C1B81 for ; Fri, 9 Sep 2016 00:36:20 +0000 (UTC) Date: Fri, 9 Sep 2016 00:36:20 +0000 (UTC) From: "Arpit Agarwal (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-9849) DiskBalancer : reduce lock path in shutdown code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 09 Sep 2016 00:36:22 -0000 [ https://issues.apache.org/jira/browse/HDFS-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475465#comment-15475465 ] Arpit Agarwal commented on HDFS-9849: ------------------------------------- The patch lgtm. The risk of not fixing it is very low right now as [~anu] mentioned but it's generally good practice not to sleep with a lock held, so I am +1 for fixing it. > DiskBalancer : reduce lock path in shutdown code > ------------------------------------------------ > > Key: HDFS-9849 > URL: https://issues.apache.org/jira/browse/HDFS-9849 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: balancer & mover > Affects Versions: HDFS-1312 > Reporter: Anu Engineer > Assignee: Yuanbo Liu > Fix For: HDFS-1312 > > Attachments: HDFS-9849.001.patch, HDFS-9849.002.patch, HDFS-9849.003.patch > > > In HDFS-9671, [~arpitagarwal] commented that we can possibly reduce the code path that is holding a lock while shutting down the diskBalancer. This jira tracks that improvement. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org