hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10912) Ozone:SCM: Add chill mode support to NodeManager.
Date Fri, 30 Sep 2016 19:29:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15536813#comment-15536813

Xiaoyu Yao commented on HDFS-10912:

Thanks @Anu for reporting the issue and posting the patch. It looks good to me overall. Below
are some minor issues:

# NIT: extra space "*  Chill mode is" 
# Typo: "Forcefully exists ""
# clearChillModeFlag(), is this for test only? add annotation for that if it is the case.

# NIT: comments below can be removed as it is covered in the class description
of NodeManager.java. I would suggest we summarize the usage of both safemode and
the new chillmode as discussed in previous comments and put it in the comments. 
107	   * Chill mode is the period where node manager is waiting for sufficient
108	   * nodes to report in.
109	   */
# getChillModeStatus(): the logic of returning different status string can be consolidated
to get a consistent string output for easy parsing or trouble shooting.
# forceExitChillMode()/forceEnterChillMode: typo "exists". Should we use "chill mode" instead
"safe mode" in the comments.

> Ozone:SCM: Add chill mode support to NodeManager.
> -------------------------------------------------
>                 Key: HDFS-10912
>                 URL: https://issues.apache.org/jira/browse/HDFS-10912
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: HDFS-10912-HDFS-7240.001.patch, HDFS-10912-HDFS-7240.002.patch
> Add chill mode support : That is to add the ability to force exit or enter chill mode.
As well as get the current chill mode status from node manager.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message