hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10903) Replace config key literal strings with config key names II: hadoop hdfs
Date Mon, 26 Sep 2016 21:56:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524298#comment-15524298
] 

Xiaoyu Yao commented on HDFS-10903:
-----------------------------------

Thanks [~liuml07] for reporting this and [~vagarychen] for posting the patch. The change looks
good to me. 
Can you also fix the "io.file.buffer.zie" usage in o.a.h.fs.contract.ContractTestUtils.java?
+1 after that is fixed. 

> Replace config key literal strings with config key names II: hadoop hdfs
> ------------------------------------------------------------------------
>
>                 Key: HDFS-10903
>                 URL: https://issues.apache.org/jira/browse/HDFS-10903
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Mingliang Liu
>            Assignee: Chen Liang
>            Priority: Minor
>         Attachments: HADOOP-13644.001.patch
>
>
> In *Hadoop HDFS*, there are some places that use config key literal strings instead of
config key names, e.g.
> {code:title=IOUtils.java}
>     copyBytes(in, out, conf.getInt("io.file.buffer.size", 4096), true);
> {code}
> We should replace places like this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message