hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-10892) Add unit tests for HDFS command 'dfs -tail' and 'dfs -stat'
Date Tue, 27 Sep 2016 23:24:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527755#comment-15527755
] 

Allen Wittenauer edited comment on HDFS-10892 at 9/27/16 11:23 PM:
-------------------------------------------------------------------

The Dockerfile that ships with Hadoop does not force a UTF-8 locale.  So it will inherit whatever
locale was running at the UNIX level. (This, BTW, is intentional.)  Apache Yetus will only
force the locale to be a UTF-8 variant if shellcheck is involved.

I'd recommend that if the test needs UTF-8, then the test should set the locale it needs and
then restore.  If setting the UTF-8 locale fails, then the test should be skipped. There's
no guarantee that a user running the test is even UTF-8 capable.


was (Author: aw):
The Dockerfile that ships with Hadoop does not force a UTF-8 locale.  So it will inherit whatever
locale was running at the UNIX level.  Apache Yetus will only force the locale to be a UTF-8
variant if shellcheck is involved.

I'd recommend that if the test needs UTF-8, then the test should set the locale it needs and
then restore.  If setting the UTF-8 locale fails, then the test should be skipped. There's
no guarantee that a user running the test is even UTF-8 capable.

> Add unit tests for HDFS command 'dfs -tail' and 'dfs -stat'
> -----------------------------------------------------------
>
>                 Key: HDFS-10892
>                 URL: https://issues.apache.org/jira/browse/HDFS-10892
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: fs, shell, test
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HDFS-10892.000.patch, HDFS-10892.001.patch, HDFS-10892.002.patch,
HDFS-10892.003.patch, HDFS-10892.004.patch
>
>
> I did not find unit test in {{trunk}} code for following cases:
> - HDFS command {{dfs -tail}}
> - HDFS command {{dfs -stat}}
> I think it still merits to have one though the commands have served us for years.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message