hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manoj Govindassamy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10876) Dispatcher#dispatch should log IOException stacktrace
Date Tue, 20 Sep 2016 19:09:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507476#comment-15507476
] 

Manoj Govindassamy commented on HDFS-10876:
-------------------------------------------

Thanks for the review. Exception is because of the proxy or target issue during balancing.
Upon these issues, 10 second delay for proxy and target are activated. So, would logging this
stacktrace as an INFO message be OK ? But, I also see your point of not spamming the logs
with stack traces and may be DEBUG for stack trace sounds like a good idea. 

[~jojochuang] any thoughts please ? 

> Dispatcher#dispatch should log IOException stacktrace
> -----------------------------------------------------
>
>                 Key: HDFS-10876
>                 URL: https://issues.apache.org/jira/browse/HDFS-10876
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: balancer & mover
>    Affects Versions: 2.6.0
>            Reporter: Wei-Chiu Chuang
>            Assignee: Manoj Govindassamy
>            Priority: Trivial
>              Labels: newbie
>         Attachments: HDFS-10876.001.patch
>
>
> This error logging should be improved. A warning log should record the stacktrace as
well.
> {code:title=Dispatcher#dispatch}
> try {
> ...
> } catch (IOException e) {
>         LOG.warn("Failed to move " + this + ": " + e.getMessage());
> ...
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message