hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Krogen (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-10843) Quota Feature Cached Size != Computed Size When Block Committed But Not Completed
Date Wed, 07 Sep 2016 01:12:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469153#comment-15469153
] 

Erik Krogen edited comment on HDFS-10843 at 9/7/16 1:11 AM:
------------------------------------------------------------

After further consideration it seems that it is probably most appropriate to continue to use
the preferred block size as the cached size until the block is actually completed rather than
just committed. This is more consistent with how the rest of the code treats the under construction
size (see comments on {{INodeFile.&#123;storagespaceConsumed,computeFileSize&#125;}}
and code in {{FileWithSnapshotFeature.updateQuotaAndCollectBlocks}} and  {{FSDirAppendOp.computeQuotaDeltaForUCBlock}});
it seems that generally the under construction / not under construction distinction is used
rather than committed vs. uncommitted. 


was (Author: xkrogen):
After further consideration it seems that it is probably most appropriate to continue to use
the preferred block size as the cached size until the block is actually completed rather than
just committed. This is more consistent with how the rest of the code treats the under construction
size (see comments on {{INodeFile.&#123;storagespaceConsumed,computeFileSize&#125;}},
{{FileWithSnapshotFeature.updateQuotaAndCollectBlocks}}, {{FSDirAppendOp.computeQuotaDeltaForUCBlock}});
it seems that generally the under construction / not under construction distinction is used
rather than committed vs. uncommitted. 

> Quota Feature Cached Size != Computed Size When Block Committed But Not Completed
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-10843
>                 URL: https://issues.apache.org/jira/browse/HDFS-10843
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs, namenode
>    Affects Versions: 2.6.0
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>
> Currently when a block has been committed but has not yet been completed, the cached
size (used for the quota feature) of the directory containing that block differs from the
computed size. This results in log messages of the following form:
> bq. ERROR namenode.NameNode (DirectoryWithQuotaFeature.java:checkStoragespace(141)) -
BUG: Inconsistent storagespace for directory /TestQuotaUpdate. Cached = 512 != Computed =
8192
> When a block is initially started under construction, the used space is conservatively
set to a full block. When the block is committed, the cached size is updated to the final
size of the block. However, the calculation of the computed size uses the full block size
until the block is completed, so in the period where the block is committed but not completed
they disagree. To fix this we need to decide which is correct and fix the other to match.
It seems to me that the cached size is correct since once the block is committed its size
will not change. 
> This can be reproduced using the following steps:
> - Create a directory with a quota
> - Start writing to a file within this directory
> - Prevent all datanodes to which the file is written from communicating the corresponding
BlockReceivedAndDeletedRequestProto to the NN temporarily (i.e. simulate a transient network
partition/delay)
> - During this time, call DistributedFileSystem.getContentSummary() on the directory with
the quota



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message