hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Chen (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-10820) Reuse closeResponder to reset the response variable in DataStreamer#run
Date Thu, 01 Sep 2016 22:52:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456864#comment-15456864
] 

Xiao Chen edited comment on HDFS-10820 at 9/1/16 10:51 PM:
-----------------------------------------------------------

I have committed this to trunk. Thanks [~linyiqun]] for the contribution.


was (Author: xiaochen):
I have committed this to trunk. Thanks [~yiqun] for the contribution.

> Reuse closeResponder to reset the response variable in DataStreamer#run
> -----------------------------------------------------------------------
>
>                 Key: HDFS-10820
>                 URL: https://issues.apache.org/jira/browse/HDFS-10820
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>            Priority: Minor
>             Fix For: 3.0.0-alpha2
>
>         Attachments: HDFS-10820.001.patch, HDFS-10820.002.patch
>
>
> When worked for HDFS-6532, I found that the error recovery will happens when responder
close fails. The related codes:
> {code}
> {code:title=DataStreamer.java|borderStyle=solid}
>   public void run() {
>     long lastPacket = Time.monotonicNow();
>     TraceScope scope = null;
>     while (!streamerClosed && dfsClient.clientRunning) {
>       // if the Responder encountered an error, shutdown Responder
>       if (errorState.hasError() && response != null) {
>         try {
>           response.close();
>           response.join();
>           response = null;
>         } catch (InterruptedException e) {
>           // If interruptedException happens, the response will not be set to null
>           // and that will lead the error recovry.
>           LOG.warn("Caught exception", e);
>         }
>       }
>       // Here need add a finally block to set response as null
>       ...
> {code}
> Can see the related comment:https://issues.apache.org/jira/browse/HDFS-6532?focusedCommentId=15448770&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15448770



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message