hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10744) Internally optimize path component resolution
Date Tue, 13 Sep 2016 06:11:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15486380#comment-15486380
] 

Zhe Zhang commented on HDFS-10744:
----------------------------------

I verified that all reported failures pass locally. In backporting, all conflicts I resolved
were due to the fact that the {{FSDirectory#resolvePath}} change were made to some code not
existing in branch-2.7. I made notes on related JIRAs that if they were to be backported to
branch-2.7, the backporter should pay attention to HDFS-10744. And actually since in this
change we updated the signature of {{resolvePath}}, it's pretty hard to miss without failing
the build.

I also made another pass of more tricky changes in {{FSDirectory}}. They were all clean in
the backport and I think the branch-2.7 patch is making the same logical changes as the branch-2.8
patch.

Pinging [~daryn] and [~kihwal] to take another look at the branch-2.7 patch. If there's no
objection I will commit tomorrow night. Thanks!

> Internally optimize path component resolution
> ---------------------------------------------
>
>                 Key: HDFS-10744
>                 URL: https://issues.apache.org/jira/browse/HDFS-10744
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 2.8.0, 3.0.0-alpha1
>
>         Attachments: HDFS-10744-branch-2.7.patch, HDFS-10744.patch
>
>
> {{FSDirectory}}'s path resolution currently uses a mixture of string & byte[][] 
conversions, back to string, back to byte[][] for {{INodesInPath}}.  Internally all path component
resolution should be byte[][]-based as the precursor to instantiating an {{INodesInPath}}
w/o the last 2 unnecessary conversions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message