hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-10713) Throttle FsNameSystem lock warnings
Date Tue, 27 Sep 2016 00:17:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524583#comment-15524583
] 

Arpit Agarwal edited comment on HDFS-10713 at 9/27/16 12:17 AM:
----------------------------------------------------------------

Thanks [~hanishakoneru] for the contribution and everyone else for the reviews and discussion.
I pushed it to trunk with the following trivial edit to satisfy checkstyle.

{code}
-          && !longestReadLockHeldInterval.compareAndSet(localLongestReadLock, readLockInterval));
+          && !longestReadLockHeldInterval.compareAndSet(localLongestReadLock,
+                                                        readLockInterval));
{code}

Hanisha if you want to post a branch-2 patch I can commit that too, I think it just needs
trivial changes to TestFSNameSystem.java to make variables accessed in the inner classes final
since Java 7 won't allow access to non-final vars.


was (Author: arpitagarwal):
Thanks [~hanishakoneru] for the contribution and everyone else for the reviews and discussion.
I pushed it to trunk with the following trivial edit to satisfy checkstyle.

{code}
-          && !longestReadLockHeldInterval.compareAndSet(localLongestReadLock, readLockInterval));
+          && !longestReadLockHeldInterval.compareAndSet(localLongestReadLock,
+                                                        readLockInterval));
{code}

Hanisha if you want to post a branch-2 patch I can commit that too, I think it just needs
trivial changes to TestFSNameSystem.java to make variables accessed in the inner classes final
since Java 7 won't allow that.

> Throttle FsNameSystem lock warnings
> -----------------------------------
>
>                 Key: HDFS-10713
>                 URL: https://issues.apache.org/jira/browse/HDFS-10713
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: logging, namenode
>            Reporter: Arpit Agarwal
>            Assignee: Hanisha Koneru
>             Fix For: 3.0.0-alpha2
>
>         Attachments: HDFS-10713.000.patch, HDFS-10713.001.patch, HDFS-10713.002.patch,
HDFS-10713.003.patch, HDFS-10713.004.patch, HDFS-10713.005.patch, HDFS-10713.006.patch, HDFS-10713.007.patch,
HDFS-10713.008.patch, HDFS-10713.009.patch, HDFS-10713.010.patch, HDFS-10713.011.patch, HDFS-10713.012.patch
>
>
> The NameNode logs a message if the FSNamesystem write lock is held by a thread for over
1 second. These messages can be throttled to at one most one per x minutes to avoid potentially
filling up NN logs. We can also log the number of suppressed notices since the last log message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message