hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Chiu Chuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10683) Make class Token$PrivateToken private
Date Thu, 29 Sep 2016 13:21:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532756#comment-15532756
] 

Wei-Chiu Chuang commented on HDFS-10683:
----------------------------------------

Retract my +1. The test failure of TestFileChecksum is related. [~jzhuge] please take a  look
again at your patch.

> Make class Token$PrivateToken private
> -------------------------------------
>
>                 Key: HDFS-10683
>                 URL: https://issues.apache.org/jira/browse/HDFS-10683
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.9.0
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Minor
>              Labels: fs, ha, security, security_token
>         Attachments: HDFS-10683.001.patch, HDFS-10683.002.patch
>
>
> Avoid {{instanceof}} or typecasting of {{Toke.PrivateToken}} by introducing an interface
method in {{Token}}. Make class {{Toke.PrivateToken}} private. Use a factory method instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message