hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lei (Eddy) Xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10636) Modify ReplicaInfo to remove the assumption that replica metadata and data are stored in java.io.File.
Date Tue, 13 Sep 2016 00:59:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485831#comment-15485831
] 

Lei (Eddy) Xu commented on HDFS-10636:
--------------------------------------

Sorry for late reply, [~chris] and [~virajith]

I think that my previous thoughts on types might put too much constraints and make things
difficult. Apologize for that.

This patch itself looks OK to me. +0. for the reason described below:

{code}
abstract public class LocalReplica extends ReplicaInfo {
}

// and 

public class FinalizedReplica extends LocalReplica {
}
{code}

My concern is that in the future, where in the class hierarchy is {{ProvidedFinalizedReplica}},
should it inherent from {{FinalizedReplica}} or {{LocalReplica}}? In such cases, is {{ProvidedFinalizedReplica}}
a {{LocalReplica}}? 



> Modify ReplicaInfo to remove the assumption that replica metadata and data are stored
in java.io.File.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-10636
>                 URL: https://issues.apache.org/jira/browse/HDFS-10636
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, fs
>            Reporter: Virajith Jalaparti
>            Assignee: Virajith Jalaparti
>         Attachments: HDFS-10636.001.patch, HDFS-10636.002.patch, HDFS-10636.003.patch,
HDFS-10636.004.patch, HDFS-10636.005.patch, HDFS-10636.006.patch, HDFS-10636.007.patch, HDFS-10636.008.patch,
HDFS-10636.009.patch, HDFS-10636.010.patch
>
>
> Replace java.io.File related APIs from {{ReplicaInfo}}, and enable the definition of
new {{ReplicaInfo}} sub-classes whose metadata and data can be present on external storages
(HDFS-9806). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message