hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaobing Zhou (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10599) DiskBalancer: Execute CLI via Shell
Date Mon, 12 Sep 2016 22:52:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485544#comment-15485544
] 

Xiaobing Zhou commented on HDFS-10599:
--------------------------------------

Thanks [~manojg] for the work, and [~anu] for the review. The patch 001 looks good. Minor
comments:
1. report command doesn't need fs option
{code}
146	    final String topReportArg = "5";
147	    final String reportArgs = String.format("%s %s -%s -%s %s",
148	        "fs", cluster.getNameNode().getNameNodeAddressHostPortString(),
{code}

2. Since PrintStream is instance member in DiskBalancerCLI, the parameter 'out' can be removed
from DiskBalancerCLI#dispatch


> DiskBalancer: Execute CLI via Shell 
> ------------------------------------
>
>                 Key: HDFS-10599
>                 URL: https://issues.apache.org/jira/browse/HDFS-10599
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: balancer & mover
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Anu Engineer
>            Assignee: Manoj Govindassamy
>         Attachments: HDFS-10599.001.patch
>
>
> DiskBalancer CLI invokes CLI functions directly instead of shell. This is not representative
of how end users use it. To provide good unit test coverage, we need to have tests where DiskBalancer
CLI is invoked via shell.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message