hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Masatake Iwasaki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10426) TestPendingInvalidateBlock failed in trunk
Date Mon, 19 Sep 2016 15:20:22 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15503750#comment-15503750
] 

Masatake Iwasaki commented on HDFS-10426:
-----------------------------------------

Thanks for the update again, [~linyiqun]. The patch almost looks good.

{noformat}
100	    // for the following operations.
101	    Thread.sleep(2000);
102	    dfs.delete(foo, true);
...
109	    Mockito.doReturn(0L).when(mockIb).getInvalidationDelay();
110	    Thread.sleep(2000);
{noformat}

You do not need these sleeps. If there is synchronization issue between threads, sleeping
is not right solution.


{noformat}
206	  private void waitForBlocksToDelete() throws Exception {
207	    GenericTestUtils.waitFor(new Supplier<Boolean>() {
208	
209	      @Override
210	      public Boolean get() {
211	        try {
212	          cluster.triggerBlockReports();
213	          Thread.sleep(2000);
...
223	    }, 6000, 60000);
224	  }
{noformat}

Since {{GenericTestUtils#waitFor}} sleeps 6000ms before retry calling {{get}}, {{get}} should
not call {{sleep}} by itself. If you think 2000ms is the right interval, you should pass it
as 2nd argument of {{GenericTestUtils#waitFor}}.

> TestPendingInvalidateBlock failed in trunk
> ------------------------------------------
>
>                 Key: HDFS-10426
>                 URL: https://issues.apache.org/jira/browse/HDFS-10426
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>         Attachments: HDFS-10426.001.patch, HDFS-10426.002.patch, HDFS-10426.003.patch,
HDFS-10426.004.patch, HDFS-10426.005.patch
>
>
> The test {{TestPendingInvalidateBlock}} failed sometimes. The stack info:
> {code}
> org.apache.hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
> testPendingDeletion(org.apache.hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock)
 Time elapsed: 7.703 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<2> but was:<1>
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.failNotEquals(Assert.java:743)
> 	at org.junit.Assert.assertEquals(Assert.java:118)
> 	at org.junit.Assert.assertEquals(Assert.java:555)
> 	at org.junit.Assert.assertEquals(Assert.java:542)
> 	at org.apache.hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock.testPendingDeletion(TestPendingInvalidateBlock.java:92)
> {code}
> It looks that the {{invalidateBlock}} has been removed before we do the check
> {code}
>     // restart NN
>     cluster.restartNameNode(true);
>     dfs.delete(foo, true);
>     Assert.assertEquals(0, cluster.getNamesystem().getBlocksTotal());
>     Assert.assertEquals(REPLICATION, cluster.getNamesystem()
>         .getPendingDeletionBlocks());
>     Assert.assertEquals(REPLICATION,
>         dfs.getPendingDeletionBlocksCount());
> {code}
> And I look into the related configurations. I found the property {{dfs.namenode.replication.interval}}
was just set as 1 second in this test. And after the delay time of {{dfs.namenode.startup.delay.block.deletion.sec}}
and the delete operation was slowly, it will cause this case. We can see the stack info before,
the failed test costs 7.7s more than 5+1 second.
> One way can improve this.
> * Increase the time of {{dfs.namenode.replication.interval}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message