hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9849) DiskBalancer : reduce lock path in shutdown code
Date Fri, 09 Sep 2016 00:36:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475465#comment-15475465
] 

Arpit Agarwal commented on HDFS-9849:
-------------------------------------

The patch lgtm. 

The risk of not fixing it is very low right now as [~anu] mentioned but it's generally good
practice not to sleep with a lock held, so I am +1 for fixing it.

> DiskBalancer : reduce lock path in shutdown code
> ------------------------------------------------
>
>                 Key: HDFS-9849
>                 URL: https://issues.apache.org/jira/browse/HDFS-9849
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: balancer & mover
>    Affects Versions: HDFS-1312
>            Reporter: Anu Engineer
>            Assignee: Yuanbo Liu
>             Fix For: HDFS-1312
>
>         Attachments: HDFS-9849.001.patch, HDFS-9849.002.patch, HDFS-9849.003.patch
>
>
> In HDFS-9671, [~arpitagarwal] commented that we can possibly reduce the code path that
is holding a lock while shutting down the diskBalancer. This jira tracks that improvement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message