hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9849) DiskBalancer : reduce lock path in shutdown code
Date Thu, 08 Sep 2016 15:40:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474195#comment-15474195
] 

Anu Engineer commented on HDFS-9849:
------------------------------------

[~yuanbo] Thanks for your patience. I am not fully convinced that we should do this. Let us
look at the downside of not having this patch.  As [~arpitagarwal] mentioned it can lock up
a requests when we are shutting down datanodes.  However if datanode is shutting down, queuing
the commands is not really useful right ?. Just to make sure that I am not missing something,
what do you think is the real benefit of fixing this issue ?

[~arpitagarwal] I would love to get your perspective on this, the code change is minor, but
I am not sure if we are achieving anything significant. An alternative approach would be to
do actually not shutdown the thread whenever we are done balancing or in the cancel path --
[~arpitagarwal] mentioned the same in an earlier code review. 


  

> DiskBalancer : reduce lock path in shutdown code
> ------------------------------------------------
>
>                 Key: HDFS-9849
>                 URL: https://issues.apache.org/jira/browse/HDFS-9849
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: balancer & mover
>    Affects Versions: HDFS-1312
>            Reporter: Anu Engineer
>            Assignee: Yuanbo Liu
>             Fix For: HDFS-1312
>
>         Attachments: HDFS-9849.001.patch, HDFS-9849.002.patch, HDFS-9849.003.patch
>
>
> In HDFS-9671, [~arpitagarwal] commented that we can possibly reduce the code path that
is holding a lock while shutting down the diskBalancer. This jira tracks that improvement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message