Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 23F2E200B81 for ; Tue, 30 Aug 2016 01:22:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 22770160AC8; Mon, 29 Aug 2016 23:22:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6A857160AB8 for ; Tue, 30 Aug 2016 01:22:26 +0200 (CEST) Received: (qmail 86477 invoked by uid 500); 29 Aug 2016 23:22:22 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 86037 invoked by uid 99); 29 Aug 2016 23:22:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Aug 2016 23:22:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E4C142C0153 for ; Mon, 29 Aug 2016 23:22:21 +0000 (UTC) Date: Mon, 29 Aug 2016 23:22:21 +0000 (UTC) From: "Lei (Eddy) Xu (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10808) DiskBalancer does not execute multi-steps plan-redux MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 29 Aug 2016 23:22:27 -0000 [ https://issues.apache.org/jira/browse/HDFS-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447388#comment-15447388 ] Lei (Eddy) Xu commented on HDFS-10808: -------------------------------------- [~anu] Thanks for the explanations. * Is {{clearExitFlag()}} duplicated to {{setRunnable()}}? * bq. Also we seem to have introduced some unintended side effects like some lines becoming no-op. I don't follow why it becomes no-ops. If someone else have set exitFlag, either way (using {{continue}} or {{break}}) here will stop the while loop, right? {code} if (!shouldRun()) { continue; } {code} * If you put a {{clearExitFlag()}} in the for loop: {code} for (Map.Entry entry : workMap.entrySet()) { blockMover.clearExitFlag(); blockMover.copyBlocks(entry.getKey(), entry.getValue()); } {code} then {{diskbalancer -cancel}} command can not actually stop {{BlockMover}} thread for multiple work items? > DiskBalancer does not execute multi-steps plan-redux > ---------------------------------------------------- > > Key: HDFS-10808 > URL: https://issues.apache.org/jira/browse/HDFS-10808 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: balancer & mover > Reporter: Anu Engineer > Assignee: Anu Engineer > Attachments: HDFS-10808.001.patch > > > This is to redo of the fix in HDFS-10598 -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org