Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EAB66200B71 for ; Wed, 31 Aug 2016 19:50:38 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 70837160AC4; Wed, 31 Aug 2016 17:50:33 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B91D8160AB4 for ; Wed, 31 Aug 2016 19:50:32 +0200 (CEST) Received: (qmail 88065 invoked by uid 500); 31 Aug 2016 17:50:21 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 87892 invoked by uid 99); 31 Aug 2016 17:50:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Aug 2016 17:50:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 2BA312C1B7F for ; Wed, 31 Aug 2016 17:50:21 +0000 (UTC) Date: Wed, 31 Aug 2016 17:50:21 +0000 (UTC) From: "Arpit Agarwal (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10742) Measurement of lock held time in FsDatasetImpl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 31 Aug 2016 17:50:39 -0000 [ https://issues.apache.org/jira/browse/HDFS-10742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452877#comment-15452877 ] Arpit Agarwal commented on HDFS-10742: -------------------------------------- Thanks [~vagarychen]. The change lgtm. A few minor comments: # The InstrumentedLock class javadoc refers to LockChecker. # Missing Javadoc for InstrumentedLock constructor. # We should add a unit test for InstrumentedLock, similar to the one for AutoCloseableLock. Couple of comments that can be handled in a separate Jira: # InstrumentedLock should not extend the concrete class AutoCloseableLock. We could make AutoCloseableLock an interface. # The thresholds in FsDatasetImpl constructor should probably be configurable. We could use the same config key being introduced by HDFS-10713. > Measurement of lock held time in FsDatasetImpl > ---------------------------------------------- > > Key: HDFS-10742 > URL: https://issues.apache.org/jira/browse/HDFS-10742 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Affects Versions: 3.0.0-alpha2 > Reporter: Chen Liang > Assignee: Chen Liang > Attachments: HDFS-10742.001.patch, HDFS-10742.002.patch, HDFS-10742.003.patch, HDFS-10742.004.patch, HDFS-10742.005.patch, HDFS-10742.006.patch, HDFS-10742.007.patch, HDFS-10742.008.patch, HDFS-10742.009.patch, HDFS-10742.010.patch > > > This JIRA proposes to measure the time the of lock of {{FsDatasetImpl}} is held by a thread. Doing so will allow us to measure lock statistics. > This can be done by extending the {{AutoCloseableLock}} lock object in {{FsDatasetImpl}}. In the future we can also consider replacing the lock with a read-write lock. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org