Return-Path: <hdfs-issues-return-167650-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 8A0BB200B85
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 31 Aug 2016 23:06:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 88D7C160AA7; Wed, 31 Aug 2016 21:06:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id D2129160AB4
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 31 Aug 2016 23:06:21 +0200 (CEST)
Received: (qmail 26990 invoked by uid 500); 31 Aug 2016 21:06:20 -0000
Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hdfs-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hdfs-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hdfs-issues@hadoop.apache.org>
List-Id: <hdfs-issues.hadoop.apache.org>
Delivered-To: mailing list hdfs-issues@hadoop.apache.org
Received: (qmail 26970 invoked by uid 99); 31 Aug 2016 21:06:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Aug 2016 21:06:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id AEBBF2C1B81
	for <hdfs-issues@hadoop.apache.org>; Wed, 31 Aug 2016 21:06:20 +0000 (UTC)
Date: Wed, 31 Aug 2016 21:06:20 +0000 (UTC)
From: "Mingliang Liu (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12994105.1470092266000.462330.1472677580712@Atlassian.JIRA>
In-Reply-To: <JIRA.12994105.1470092266000@Atlassian.JIRA>
References: <JIRA.12994105.1470092266000@Atlassian.JIRA> <JIRA.12994105.1470092266496@arcas>
Subject: [jira] [Commented] (HDFS-10713) Throttle FsNameSystem lock warnings
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Wed, 31 Aug 2016 21:06:22 -0000


    [ https://issues.apache.org/jira/browse/HDFS-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453359#comment-15453359 ] 

Mingliang Liu commented on HDFS-10713:
--------------------------------------

{code:title=DFSConfigKeys.java}
414	  // Threshold for how long the write lock warnings must be suppressed
415	  public static final String DFS_LOCK_SUPPRESS_WARNING_INTERVAL_MS_KEY =
416	      "dfs.lock.suppress.warning.interval.ms";
417	  public static final long DFS_LOCK_SUPPRESS_WARNING_INTERVAL_MS_DEFAULT =
418	      120000L;
{code}
And
{code:title=hdfs-default.xml}
	2626	<property>
2627	  <name>dfs.lock.suppress.warning.interval.ms</name>
2628	  <value>1000</value>
2629	  <description>The interval between reporting lock warnings.
2630	  </description>
2631	</property>
2632	
{code}
I believe the default value of config key {{dfs.lock.suppress.warning.interval.ms}} is 2 mins not 1 second?

Minor comments:
In line 1571, message {{"Number of suppressed write-lock reports: " + numSuppressedWarnings);}} should have a "\n" or "\t" before it.

> Throttle FsNameSystem lock warnings
> -----------------------------------
>
>                 Key: HDFS-10713
>                 URL: https://issues.apache.org/jira/browse/HDFS-10713
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: logging, namenode
>            Reporter: Arpit Agarwal
>            Assignee: Hanisha Koneru
>         Attachments: HDFS-10713.000.patch, HDFS-10713.001.patch, HDFS-10713.002.patch
>
>
> The NameNode logs a message if the FSNamesystem write lock is held by a thread for over 1 second. These messages can be throttled to at one most one per x minutes to avoid potentially filling up NN logs. We can also log the number of suppressed notices since the last log message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org