Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3D912200B49 for ; Wed, 3 Aug 2016 23:41:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3C489160A86; Wed, 3 Aug 2016 21:41:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8DF0E160AB1 for ; Wed, 3 Aug 2016 23:41:22 +0200 (CEST) Received: (qmail 68526 invoked by uid 500); 3 Aug 2016 21:41:21 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 67994 invoked by uid 99); 3 Aug 2016 21:41:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Aug 2016 21:41:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 20B3D2C0033 for ; Wed, 3 Aug 2016 21:41:21 +0000 (UTC) Date: Wed, 3 Aug 2016 21:41:21 +0000 (UTC) From: "Chen Liang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10682) Replace FsDatasetImpl object lock with a separate lock object MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 03 Aug 2016 21:41:23 -0000 [ https://issues.apache.org/jira/browse/HDFS-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406669#comment-15406669 ] Chen Liang commented on HDFS-10682: ----------------------------------- Thanks to [~arpitagarwal] for the advise! I moved the separate lock class to hadoop common utils and filed HADOOP-13466 to keep track of it. Will later on update this JIRA to just use the lock class. > Replace FsDatasetImpl object lock with a separate lock object > ------------------------------------------------------------- > > Key: HDFS-10682 > URL: https://issues.apache.org/jira/browse/HDFS-10682 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Reporter: Chen Liang > Assignee: Chen Liang > Attachments: HDFS-10682.001.patch, HDFS-10682.002.patch, HDFS-10682.003.patch, HDFS-10682.004.patch, HDFS-10682.005.patch, HDFS-10682.006.patch, HDFS-10682.007.patch, HDFS-10682.008.patch, HDFS-10682.009.patch > > > This Jira proposes to replace the FsDatasetImpl object lock with a separate lock object. Doing so will make it easier to measure lock statistics like lock held time and warn about potential lock contention due to slow disk operations. > In the future we can also consider replacing the lock with a read-write lock. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org