hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fenghua Hu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10804) Use finer-granularity lock for ReplicaMap
Date Tue, 30 Aug 2016 23:14:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450435#comment-15450435
] 

Fenghua Hu commented on HDFS-10804:
-----------------------------------

[~vagarychen], thanks for the suggestion.
My intention is to avoid using FsDatasetImpl for synchronization for performance, so a private
object is introduced. But I am not quite sure if we CAN DO this. What do you think?


> Use finer-granularity lock for ReplicaMap
> -----------------------------------------
>
>                 Key: HDFS-10804
>                 URL: https://issues.apache.org/jira/browse/HDFS-10804
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>    Affects Versions: 3.0.0-beta1
>            Reporter: Fenghua Hu
>            Assignee: Fenghua Hu
>            Priority: Minor
>         Attachments: HDFS-10804-001.patch, HDFS-10804-002.patch
>
>
> In currently implementation, ReplicaMap takes an external object as lock for synchronization.
> In function FsDatasetImpl#FsDatasetImpl(), the object is for synchronization is "this",
i.e. FsDatasetImpl: 
> volumeMap = new ReplicaMap(this);
> and in private FsDatasetImpl#addVolume(), "this" object is used for synchronization as
well.
> ReplicaMap tempVolumeMap = new ReplicaMap(this);
> I am not sure if we really need so big object FsDatasetImpl  for ReplicaMap's synchronization.
If it's not necessary, this could reduce lock contention on FsDatasetImpl object and improve
performance. 
> Could you please give me some suggestions? Thanks a lot!
> Fenghua



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message