hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10742) Measurement of lock held time in FsDatasetImpl
Date Wed, 31 Aug 2016 17:50:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452877#comment-15452877
] 

Arpit Agarwal commented on HDFS-10742:
--------------------------------------

Thanks [~vagarychen]. The change lgtm. A few minor comments:
# The InstrumentedLock class javadoc refers to LockChecker. 
# Missing Javadoc for InstrumentedLock constructor.
# We should add a unit test for InstrumentedLock, similar to the one for AutoCloseableLock.

Couple of comments that can be handled in a separate Jira:
# InstrumentedLock should not extend the concrete class AutoCloseableLock. We could make AutoCloseableLock
an interface.
# The thresholds in FsDatasetImpl constructor should probably be configurable. We could use
the same config key being introduced by HDFS-10713.

> Measurement of lock held time in FsDatasetImpl
> ----------------------------------------------
>
>                 Key: HDFS-10742
>                 URL: https://issues.apache.org/jira/browse/HDFS-10742
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>         Attachments: HDFS-10742.001.patch, HDFS-10742.002.patch, HDFS-10742.003.patch,
HDFS-10742.004.patch, HDFS-10742.005.patch, HDFS-10742.006.patch, HDFS-10742.007.patch, HDFS-10742.008.patch,
HDFS-10742.009.patch, HDFS-10742.010.patch
>
>
> This JIRA proposes to measure the time the of lock of {{FsDatasetImpl}} is held by a
thread. Doing so will allow us to measure lock statistics.
> This can be done by extending the {{AutoCloseableLock}} lock object in {{FsDatasetImpl}}.
In the future we can also consider replacing the lock with a read-write lock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message