hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10682) Replace FsDatasetImpl object lock with a separate lock object
Date Wed, 03 Aug 2016 18:00:23 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406317#comment-15406317
] 

Arpit Agarwal commented on HDFS-10682:
--------------------------------------

Thanks for working through the patch iterations [~vagarychen]! The v8 patch is looking good.
Just a few minor comments:
# AutoCloseableLock should not extend ReentrantLock, it already contains a lock object.
# Unused function FsDatasetSpi#releaseDatasetLock and descendants should be removed.

+1 with these addressed.

> Replace FsDatasetImpl object lock with a separate lock object
> -------------------------------------------------------------
>
>                 Key: HDFS-10682
>                 URL: https://issues.apache.org/jira/browse/HDFS-10682
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>         Attachments: HDFS-10682.001.patch, HDFS-10682.002.patch, HDFS-10682.003.patch,
HDFS-10682.004.patch, HDFS-10682.005.patch, HDFS-10682.006.patch, HDFS-10682.007.patch, HDFS-10682.008.patch
>
>
> This Jira proposes to replace the FsDatasetImpl object lock with a separate lock object.
Doing so will make it easier to measure lock statistics like lock held time and warn about
potential lock contention due to slow disk operations.
> In the future we can also consider replacing the lock with a read-write lock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message