hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Chiu Chuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10652) Add a unit test for HDFS-4660
Date Thu, 25 Aug 2016 13:17:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436835#comment-15436835
] 

Wei-Chiu Chuang commented on HDFS-10652:
----------------------------------------

Thanks [~yzhangal] that's great news!
I had a quick glance at the patch and looks good overall. One comment: is it necessary to
change the log message in {{FsDatasetImpl}}? I get that it helps debugging in the unit test,
but doesn't seem to be needed for code. Similarly there's another log message change in DataNode
that seems not necessary.

Also I think if you can extract this
{code}
if ((replicaInfo.getBytesOnDisk() / chunkSize) -
                  (replicaInfo.getBytesAcked() / chunkSize) >= 1)
{code}
to a small wrapper method, it helps understand the condition it tests.

> Add a unit test for HDFS-4660
> -----------------------------
>
>                 Key: HDFS-10652
>                 URL: https://issues.apache.org/jira/browse/HDFS-10652
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode, hdfs
>            Reporter: Yongjun Zhang
>            Assignee: Vinayakumar B
>         Attachments: HDFS-10652-002.patch, HDFS-10652.001.patch, HDFS-10652.003.patch,
HDFS-10652.004.patch, HDFS-10652.005.patch, HDFS-10652.006.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message