hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Surendra Singh Lilhore (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10608) Include event for AddBlock in Inotify Event Stream
Date Wed, 10 Aug 2016 10:40:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415097#comment-15415097
] 

Surendra Singh Lilhore commented on HDFS-10608:
-----------------------------------------------

bq. Are you okay with keeping penultimateBlock in the event?
okay... :)

one more think I want to add here..

{code}
+    public Block getLastBlock() {
+      return lastBlock;
+    }
+
+    public Block getPenultimateBlock() {
+      return penultimateBlock;
+    }
{code}

We should not return {{Block}} object, its audience is Private.
{code}
@InterfaceAudience.Private
@InterfaceStability.Evolving
public class Block implements Writable, Comparable<Block> {
  public static final String BLOCK_FILE_PREFIX = "blk_";
{code}

> Include event for AddBlock in Inotify Event Stream
> --------------------------------------------------
>
>                 Key: HDFS-10608
>                 URL: https://issues.apache.org/jira/browse/HDFS-10608
>             Project: Hadoop HDFS
>          Issue Type: Task
>            Reporter: churro morales
>            Priority: Minor
>         Attachments: HDFS-10608.patch, HDFS-10608.v1.patch
>
>
> It would be nice to have an AddBlockEvent in the INotify pipeline.  Based on discussions
from mailing list:
> http://mail-archives.apache.org/mod_mbox/hadoop-hdfs-dev/201607.mbox/%3C1467743792.4040080.657624289.7BE240AD%40webmail.messagingengine.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message