hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7859) Erasure Coding: Persist erasure coding policies in NameNode
Date Wed, 17 Aug 2016 23:56:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425624#comment-15425624
] 

Zhe Zhang commented on HDFS-7859:
---------------------------------

Thanks [~xinwei] for the update! Patch LGTM overall. A few comments:
# {{ErasureCodingPolicyManager#saveState}} should create a smaller array at the beginning:
{code}
    List<ErasureCodingPolicyProto> ecPolicies = Lists
        .newArrayListWithCapacity(activePoliciesByName.size());
{code}
It should calculate {{userAddedPoliciesCount}] at this point and use it to initiate {{ecPolicies}}.
# bq. About 3 and 4, I think the current method name and usage may be more suitable,
Makes sense.
# Could you address the checkstyle and findbug issues?

I think we are very close on this one now.

> Erasure Coding: Persist erasure coding policies in NameNode
> -----------------------------------------------------------
>
>                 Key: HDFS-7859
>                 URL: https://issues.apache.org/jira/browse/HDFS-7859
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Kai Zheng
>            Assignee: Xinwei Qin 
>              Labels: BB2015-05-TBR, hdfs-ec-3.0-must-do
>         Attachments: HDFS-7859-HDFS-7285.002.patch, HDFS-7859-HDFS-7285.002.patch, HDFS-7859-HDFS-7285.003.patch,
HDFS-7859.001.patch, HDFS-7859.002.patch, HDFS-7859.004.patch, HDFS-7859.005.patch, HDFS-7859.006.patch
>
>
> In meetup discussion with [~zhz] and [~jingzhao], it's suggested that we persist EC schemas
in NameNode centrally and reliably, so that EC zones can reference them by name efficiently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message