Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 20 Jul 2016 12:07:21 +0000 (UTC)
From: "Yiqun Lin (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12991091.1469016432000.82274.1469016441024@Atlassian.JIRA>
In-Reply-To: <JIRA.12991091.1469016432000@Atlassian.JIRA>
References: <JIRA.12991091.1469016432000@Atlassian.JIRA> <JIRA.12991091.1469016432346@arcas>
Subject: [jira] [Created] (HDFS-10658) Reduce JsonFactory instance
 allocation in StartupProgressServlet
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 20 Jul 2016 12:07:22 -0000

Yiqun Lin created HDFS-10658:
--------------------------------

             Summary: Reduce JsonFactory instance allocation in StartupProgressServlet
                 Key: HDFS-10658
                 URL: https://issues.apache.org/jira/browse/HDFS-10658
             Project: Hadoop HDFS
          Issue Type: Bug
            Reporter: Yiqun Lin
            Assignee: Yiqun Lin


Now in class {{StartupProgressServlet}}, it will always create a new {{JsonFactory}} instance to create a JsonGenerator. The codes:
{code}
  protected void doGet(HttpServletRequest req, HttpServletResponse resp)
      throws IOException {
    resp.setContentType("application/json; charset=UTF-8");
    StartupProgress prog = NameNodeHttpServer.getStartupProgressFromContext(
      getServletContext());
    StartupProgressView view = prog.createView();
    JsonGenerator json = new JsonFactory().createJsonGenerator(resp.getWriter());
    try {
      json.writeStartObject();
      json.writeNumberField(ELAPSED_TIME, view.getElapsedTime());
      json.writeNumberField(PERCENT_COMPLETE, view.getPercentComplete());
      json.writeArrayFieldStart(PHASES);
      ...
{code}
We can reuse the instance and reduce {{JsonFactory instance}} allocation.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org