Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 14 Jul 2016 17:10:20 +0000 (UTC)
From: "Yongjun Zhang (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12989436.1468498938000.30213.1468516220669@Atlassian.JIRA>
In-Reply-To: <JIRA.12989436.1468498938000@Atlassian.JIRA>
References: <JIRA.12989436.1468498938000@Atlassian.JIRA> <JIRA.12989436.1468498938231@arcas>
Subject: [jira] [Commented] (HDFS-10626) VolumeScanner prints incorrect
 IOException in reportBadBlocks operation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 14 Jul 2016 17:10:22 -0000


    [ https://issues.apache.org/jira/browse/HDFS-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15377289#comment-15377289 ] 

Yongjun Zhang commented on HDFS-10626:
--------------------------------------

HI [~linyiqun],

Thanks for reporting and working on the issue. I made a similar comment here

https://issues.apache.org/jira/browse/HDFS-10625?focusedCommentId=15377247&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15377247

I think it's helpful to report more info about the replica when there is any issue.

Thanks.


> VolumeScanner prints incorrect IOException in reportBadBlocks operation
> -----------------------------------------------------------------------
>
>                 Key: HDFS-10626
>                 URL: https://issues.apache.org/jira/browse/HDFS-10626
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>            Priority: Minor
>         Attachments: HDFS-10626.001.patch
>
>
> VolumeScanner throws incorrect IOException in {{datanode.reportBadBlocks}}. The related codes:
> {code}
>     public void handle(ExtendedBlock block, IOException e) {
>       FsVolumeSpi volume = scanner.volume;
>       ...
>       try {
>         scanner.datanode.reportBadBlocks(block, volume);
>       } catch (IOException ie) {
>         // This is bad, but not bad enough to shut down the scanner.
>         LOG.warn("Cannot report bad " + block.getBlockId(), e);
>       }
>     }
> {code}
> The IOException that printed in the log should be {{ie}} rather than {{e}} which was passed in method {{handle(ExtendedBlock block, IOException e)}}.
> It will be a important info that can help us to know why datanode reporBadBlocks failed.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org