Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 26 Jul 2016 08:43:20 +0000 (UTC)
From: "Steve Loughran (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12988396.1468264502000.132554.1469522600944@Atlassian.JIRA>
In-Reply-To: <JIRA.12988396.1468264502000@Atlassian.JIRA>
References: <JIRA.12988396.1468264502000@Atlassian.JIRA> <JIRA.12988396.1468264502649@arcas>
Subject: [jira] [Commented] (HDFS-10610) DfsClient doesn't add hdfs-site.xml
 as a resource
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 26 Jul 2016 08:43:23 -0000


    [ https://issues.apache.org/jira/browse/HDFS-10610?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1539=
3441#comment-15393441 ]=20

Steve Loughran commented on HDFS-10610:
---------------------------------------

I think my stance on HdfsConfiguration is well documented: whether the HDFS=
 team choose to accept it or not, it's a defacto part of the public API, it=
s constants are imported downstream, hdfs-site is expected to be loaded =E2=
=80=94and if you change things without asking people downstream are unhappy=
. HDFS-9301 spells out my concerns in more detail.

+1 for for making it public.=20

In YARN-679, my generic service launcher, I explicitly load in the hdfs-sit=
e and yarn-site XML files early, plus you can specify extra resources (hbas=
e-site.xml) to also load. This gets everything pulled in before you go anyw=
here near a filesystem API *or UGI*.

> DfsClient doesn't add hdfs-site.xml as a resource
> -------------------------------------------------
>
>                 Key: HDFS-10610
>                 URL: https://issues.apache.org/jira/browse/HDFS-10610
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.8.0
>            Reporter: Eric Badger
>
> Instantiating a new DfsClient used to add hdfs-site.xml as a resource in =
2.7, but that compatibility has been broken in 2.8. This only accidentally =
worked in 2.7, since DfsClient would load HdfsConstants, which would in tur=
n create the static IO_FILE_BUFFER_SIZE, which would instantiate an HdfsCon=
figuration, which would finally add hdfs-site.xml.=20
> In 2.8, IO_FILE_BUFFER_SIZE no longer exists in HdfsConstants.java and so=
 this no longer works out of coincidence.=20


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org