Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 86F3D200B3C for ; Wed, 13 Jul 2016 08:55:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 85936160A6E; Wed, 13 Jul 2016 06:55:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CEA7F160A57 for ; Wed, 13 Jul 2016 08:55:21 +0200 (CEST) Received: (qmail 88324 invoked by uid 500); 13 Jul 2016 06:55:20 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 88289 invoked by uid 99); 13 Jul 2016 06:55:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jul 2016 06:55:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 815DC2C02A7 for ; Wed, 13 Jul 2016 06:55:20 +0000 (UTC) Date: Wed, 13 Jul 2016 06:55:20 +0000 (UTC) From: "Zhe Zhang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10544) Balancer doesn't work with IPFailoverProxyProvider MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 13 Jul 2016 06:55:22 -0000 [ https://issues.apache.org/jira/browse/HDFS-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374470#comment-15374470 ] Zhe Zhang commented on HDFS-10544: ---------------------------------- Committed v5 patch to trunk, branch-2, and branch-2.8. I'm working on resolving branch-2.7 conflicts. > Balancer doesn't work with IPFailoverProxyProvider > -------------------------------------------------- > > Key: HDFS-10544 > URL: https://issues.apache.org/jira/browse/HDFS-10544 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Zhe Zhang > Assignee: Zhe Zhang > Fix For: 2.8.0, 2.9.0, 3.0.0-alpha1 > > Attachments: HDFS-10544.00.patch, HDFS-10544.01.patch, HDFS-10544.02.patch, HDFS-10544.03.patch, HDFS-10544.04.patch, HDFS-10544.05.patch > > > Right now {{Balancer}} gets the NN URIs through {{DFSUtil#getNameServiceUris}}, which returns logical URIs in HA is enabled. If {{IPFailoverProxyProvider}} is used, {{Balancer}} will not be able to start. > I think the bug is at {{DFSUtil#getNameServiceUris}}: > {code} > for (String nsId : getNameServiceIds(conf)) { > if (HAUtil.isHAEnabled(conf, nsId)) { > // Add the logical URI of the nameservice. > try { > ret.add(new URI(HdfsConstants.HDFS_URI_SCHEME + "://" + nsId)); > {code} > Then {{if}} clause should also consider if the {{FailoverProxyProvider}} has {{useLogicalURI}} enabled. If not, {{getNameServiceUris}} should try to resolve the physical URI for this nsId. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org