hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10676) Add namenode metric to measure time spent in generating EDEKs
Date Wed, 27 Jul 2016 19:21:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396198#comment-15396198

Xiaoyu Yao commented on HDFS-10676:

Thanks [~hanishakoneru] for reporting the issue/posting the patch and [~arpitagarwal] for
the reviews. 
The code change in patch v03 looks good to me. Just a few comments on the unit test:

1. NIT: clusterTestGenerateEDEKTime is too verbose, just cluster is good as it is the only
cluster used in the test case.

2. Test cluster may not shutdown when exception happened during the test. This could cause
subsequent test failures. You may wrap it with try/final or even better with the new Java
try with resources semantics to ensure a test cluster clean up.

3. NIT: There are a few test wrapper (e.g., DFSTestUtil#createFile ) you can use to simplify
test file creation below. 

4. checkstyle issues.

> Add namenode metric to measure time spent in generating EDEKs
> -------------------------------------------------------------
>                 Key: HDFS-10676
>                 URL: https://issues.apache.org/jira/browse/HDFS-10676
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>              Labels: metrics, namenode
>         Attachments: HDFS-10676.000.patch, HDFS-10676.001.patch, HDFS-10676.002.patch,
> A metric to measure the time spent by Namenode in interacting with Key Management System

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message