hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-10641) TestBlockManager#testBlockReportQueueing fails intermittently
Date Wed, 27 Jul 2016 00:01:40 GMT

     [ https://issues.apache.org/jira/browse/HDFS-10641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mingliang Liu updated HDFS-10641:
---------------------------------
    Attachment: HDFS-10641.000.patch

Thanks [~shahrs87] for helping us keep the full test logs.

I think the root cause here is that, the main test thread depends on the {{CountDownLatch}}
to check the {{FutureTask}}'s state. Chances are that the future task successfully counts
down latch, and is gonna update its internal state. While in this interval, the main thread
returns from waiting the latch, and then asserts the task internal state {{isDone()}}. This
is a race condition. This rarely happens and does not affect the main rationale of the test.

A simple fix, as the uber jira proposes, is to retry the assertion using {{GenericTestUtils.waitFor()}}.
[~daryn], does this make sense? Thanks.

> TestBlockManager#testBlockReportQueueing fails intermittently
> -------------------------------------------------------------
>
>                 Key: HDFS-10641
>                 URL: https://issues.apache.org/jira/browse/HDFS-10641
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode, test
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HDFS-10641.000.patch
>
>
> See example failing [stack trace|https://builds.apache.org/job/PreCommit-HADOOP-Build/9996/testReport/org.apache.hadoop.hdfs.server.blockmanagement/TestBlockManager/testBlockReportQueueing/].
> h6. Stacktrace
> {code}
> java.lang.AssertionError: null
> 	at org.junit.Assert.fail(Assert.java:86)
> 	at org.junit.Assert.assertTrue(Assert.java:41)
> 	at org.junit.Assert.assertTrue(Assert.java:52)
> 	at org.apache.hadoop.hdfs.server.blockmanagement.TestBlockManager.testBlockReportQueueing(TestBlockManager.java:1074)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message