hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10600) PlanCommand#getThrsholdPercentage should not use throughput value.
Date Fri, 15 Jul 2016 02:15:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378758#comment-15378758
] 

Yiqun Lin commented on HDFS-10600:
----------------------------------

Thanks a lot for the commit, [~eddyxu]!

> PlanCommand#getThrsholdPercentage should not use throughput value.
> ------------------------------------------------------------------
>
>                 Key: HDFS-10600
>                 URL: https://issues.apache.org/jira/browse/HDFS-10600
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: diskbalancer
>    Affects Versions: 2.9.0, 3.0.0-beta1
>            Reporter: Lei (Eddy) Xu
>            Assignee: Yiqun Lin
>             Fix For: 3.0.0-alpha1
>
>         Attachments: HDFS-10600.001.patch, HDFS-10600.002.patch
>
>
> In {{PlanCommand#getThresholdPercentage}}
> {code}
>  private double getThresholdPercentage(CommandLine cmd) {
> ....
>     if ((value <= 0.0) || (value > 100.0)) {
>       value = getConf().getDouble(
>           DFSConfigKeys.DFS_DISK_BALANCER_MAX_DISK_THRUPUT,
>           DFSConfigKeys.DFS_DISK_BALANCER_MAX_DISK_THRUPUT_DEFAULT);
>     }
>     return value;
>   }
> {code}
> {{DISK_THROUGHPUT}} has the unit of "MB", so it does not make sense to return {{throughput}}
as a percentage value.
> Btw, we should use {{THROUGHPUT}} instead of {{THRUPUT}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message