hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10467) Router-based HDFS federation
Date Fri, 01 Jul 2016 21:03:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359625#comment-15359625
] 

Hadoop QA commented on HDFS-10467:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 25s{color} | {color:blue}
Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  1s{color} | {color:blue}
Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 15 new or modified test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 41s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 43s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m 14s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 45s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 56s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 31s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m  8s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 45s{color} |
{color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 12s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 29s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 49s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green}  6m 49s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  6m 49s{color} | {color:red}
root generated 3 new + 706 unchanged - 2 fixed = 709 total (was 708) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  1m 48s{color}
| {color:orange} root: The patch generated 478 new + 1183 unchanged - 5 fixed = 1661 total
(was 1188) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  2m  1s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 31s{color}
| {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red}  0m 12s{color} | {color:red}
The patch generated 4 new + 74 unchanged - 1 fixed = 78 total (was 75) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  1s{color} | {color:red}
The patch 36 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  2s{color} | {color:green}
The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  2m  7s{color} | {color:red}
hadoop-hdfs-project/hadoop-hdfs generated 37 new + 0 unchanged - 0 fixed = 37 total (was 0)
{color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  1m  1s{color} | {color:red}
hadoop-hdfs-project_hadoop-hdfs generated 4 new + 7 unchanged - 0 fixed = 11 total (was 7)
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  8m 48s{color} | {color:green}
hadoop-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 60m 50s{color} | {color:red}
hadoop-hdfs in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 28s{color} | {color:red}
The patch generated 11 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}114m 18s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs-project/hadoop-hdfs |
|  |  org.apache.hadoop.hdfs.server.federation.locator.PathTreeNode.toString(int) concatenates
strings using + in a loop  At PathTreeNode.java:in a loop  At PathTreeNode.java:[line 130]
|
|  |  Unread field:StateStoreMetrics.java:[line 56] |
|  |  Synchronization performed on java.util.concurrent.CopyOnWriteArrayList in org.apache.hadoop.hdfs.server.federation.router.ConnectionManager$1.run()
 At ConnectionManager.java:org.apache.hadoop.hdfs.server.federation.router.ConnectionManager$1.run()
 At ConnectionManager.java:[line 138] |
|  |  Synchronization performed on java.util.concurrent.CopyOnWriteArrayList in org.apache.hadoop.hdfs.server.federation.router.ConnectionManager$CleanupTask.run()
 At ConnectionManager.java:org.apache.hadoop.hdfs.server.federation.router.ConnectionManager$CleanupTask.run()
 At ConnectionManager.java:[line 237] |
|  |  Should org.apache.hadoop.hdfs.server.federation.router.NamenodeHearbeatService$NamenodeStatusReport
be a _static_ inner class?  At NamenodeHearbeatService.java:inner class?  At NamenodeHearbeatService.java:[lines
81-131] |
|  |  Unread public/protected field:At NamenodeHearbeatService.java:[line 85] |
|  |  org.apache.hadoop.hdfs.server.federation.router.Router.initAndStartRouter(Configuration,
boolean) invokes System.exit(...), which shuts down the entire virtual machine  At Router.java:shuts
down the entire virtual machine  At Router.java:[line 578] |
|  |  Exception is caught when Exception is not thrown in org.apache.hadoop.hdfs.server.federation.router.Router.getConnection(MembershipStateEntity)
 At Router.java:is not thrown in org.apache.hadoop.hdfs.server.federation.router.Router.getConnection(MembershipStateEntity)
 At Router.java:[line 963] |
|  |  org.apache.hadoop.hdfs.server.federation.router.Router$CustomSocketFactory doesn't override
org.apache.hadoop.net.StandardSocketFactory.equals(Object)  At Router.java:At Router.java:[line
1] |
|  |  Should org.apache.hadoop.hdfs.server.federation.router.Router$CustomSocketFactory be
a _static_ inner class?  At Router.java:inner class?  At Router.java:[lines 366-374] |
|  |  Redundant nullcheck of connection, which is known to be non-null in org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer$DefaultLookup.getClient()
 Redundant null check at RouterRpcServer.java:is known to be non-null in org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer$DefaultLookup.getClient()
 Redundant null check at RouterRpcServer.java:[line 950] |
|  |  org.apache.hadoop.hdfs.server.federation.statestore.StateStore.overrideRegistration(String,
String, MembershipStateEntity$FederationNamenodeServiceState) does not release lock on all
exception paths  At StateStore.java:release lock on all exception paths  At StateStore.java:[line
784] |
|  |  org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.deserializeObject(Object,
Class) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead  At StateStoreDriver.java:constructor;
use Boolean.valueOf(...) instead  At StateStoreDriver.java:[line 487] |
|  |  Primitive boxed just to call toString in org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.serializeObject(Object,
Class)  At StateStoreDriver.java:toString in org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.serializeObject(Object,
Class)  At StateStoreDriver.java:[line 453] |
|  |  org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.deserializeObject(Object,
Class) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead
 At StateStoreDriver.java:Integer(String) constructor; use Integer.valueOf(String) instead
 At StateStoreDriver.java:[line 485] |
|  |  org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.deserializeObject(Object,
Class) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead
 At StateStoreDriver.java:Long(String) constructor; use Long.valueOf(String) instead  At StateStoreDriver.java:[line
483] |
|  |  org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.serializeObject(Object,
Class) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead  At
StateStoreDriver.java:Long(long) constructor; use Long.valueOf(long) instead  At StateStoreDriver.java:[line
453] |
|  |  Redundant nullcheck of results, which is known to be non-null in org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.getSingle(Class,
Map)  Redundant null check at StateStoreDriver.java:is known to be non-null in org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.getSingle(Class,
Map)  Redundant null check at StateStoreDriver.java:[line 288] |
|  |  org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.filterMultiple(Map,
Iterable) makes inefficient use of keySet iterator instead of entrySet iterator  At StateStoreDriver.java:of
keySet iterator instead of entrySet iterator  At StateStoreDriver.java:[line 206] |
|  |  Found reliance on default encoding in org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFile.getReader(Class):in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFile.getReader(Class):
new java.io.FileReader(File)  At StateStoreFile.java:[line 103] |
|  |  Found reliance on default encoding in org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFile.getWriter(Class):in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFile.getWriter(Class):
new java.io.FileWriter(File, boolean)  At StateStoreFile.java:[line 119] |
|  |  Found reliance on default encoding in org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFileSystem.getReader(Class):in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFileSystem.getReader(Class):
new java.io.InputStreamReader(InputStream)  At StateStoreFileSystem.java:[line 132] |
|  |  Found reliance on default encoding in org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFileSystem.getWriter(Class):in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFileSystem.getWriter(Class):
new java.io.OutputStreamWriter(OutputStream)  At StateStoreFileSystem.java:[line 149] |
|  |  Found reliance on default encoding in org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper.writeAll(Collection,
Class):in org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper.writeAll(Collection,
Class): String.getBytes()  At StateStoreZooKeeper.java:[line 380] |
|  |  Inconsistent synchronization of org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper.zkAuths;
locked 50% of time  Unsynchronized access at StateStoreZooKeeper.java:50% of time  Unsynchronized
access at StateStoreZooKeeper.java:[line 96] |
|  |  Inconsistent synchronization of org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper.zkHost;
locked 50% of time  Unsynchronized access at StateStoreZooKeeper.java:50% of time  Unsynchronized
access at StateStoreZooKeeper.java:[line 92] |
|  |  Redundant nullcheck of znode, which is known to be non-null in org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper.deleteAll(Class)
 Redundant null check at StateStoreZooKeeper.java:is known to be non-null in org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper.deleteAll(Class)
 Redundant null check at StateStoreZooKeeper.java:[line 451] |
|  |  Redundant nullcheck of znode, which is known to be non-null in org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper.getAll(Class)
 Redundant null check at StateStoreZooKeeper.java:is known to be non-null in org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper.getAll(Class)
 Redundant null check at StateStoreZooKeeper.java:[line 333] |
|  |  Found reliance on default encoding in org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper$ZKData.getData():in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper$ZKData.getData():
new String(byte[])  At StateStoreZooKeeper.java:[line 261] |
|  |  Should org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper$ZKData
be a _static_ inner class?  At StateStoreZooKeeper.java:inner class?  At StateStoreZooKeeper.java:[lines
256-261] |
|  |  Invocation of toString on components in org.apache.hadoop.hdfs.server.federation.statestore.model.BaseEntity.createEntity(String,
StateStoreDriver, Class, boolean)  At BaseEntity.java:in org.apache.hadoop.hdfs.server.federation.statestore.model.BaseEntity.createEntity(String,
StateStoreDriver, Class, boolean)  At BaseEntity.java:[line 257] |
|  |  Exception is caught when Exception is not thrown in org.apache.hadoop.hdfs.server.federation.statestore.model.BaseEntity.serialize(StateStoreDriver,
boolean)  At BaseEntity.java:is not thrown in org.apache.hadoop.hdfs.server.federation.statestore.model.BaseEntity.serialize(StateStoreDriver,
boolean)  At BaseEntity.java:[line 311] |
|  |  org.apache.hadoop.hdfs.server.federation.statestore.model.BaseEntity.generateMashupKey(Map)
makes inefficient use of keySet iterator instead of entrySet iterator  At BaseEntity.java:keySet
iterator instead of entrySet iterator  At BaseEntity.java:[line 180] |
|  |  Nullcheck of BaseEntity.dateModified at line 215 of value previously dereferenced in
org.apache.hadoop.hdfs.server.federation.statestore.model.MembershipStateEntity.inflate(long)
 At MembershipStateEntity.java:215 of value previously dereferenced in org.apache.hadoop.hdfs.server.federation.statestore.model.MembershipStateEntity.inflate(long)
 At MembershipStateEntity.java:[line 213] |
|  |  Invocation of toString on components in org.apache.hadoop.hdfs.server.federation.statestore.model.MountTableEntity.getLocations(String)
 At MountTableEntity.java:in org.apache.hadoop.hdfs.server.federation.statestore.model.MountTableEntity.getLocations(String)
 At MountTableEntity.java:[line 149] |
|  |  Invocation of toString on subComponents in org.apache.hadoop.hdfs.server.federation.statestore.model.MountTableEntity.getLocations(String)
 At MountTableEntity.java:in org.apache.hadoop.hdfs.server.federation.statestore.model.MountTableEntity.getLocations(String)
 At MountTableEntity.java:[line 159] |
|  |  new org.apache.hadoop.hdfs.server.federation.statestore.model.MountTableEntity(String,
Map) makes inefficient use of keySet iterator instead of entrySet iterator  At MountTableEntity.java:use
of keySet iterator instead of entrySet iterator  At MountTableEntity.java:[line 74] |
| Failed junit tests | hadoop.hdfs.server.federation.router.TestRouterRpc |
|   | hadoop.hdfs.server.federation.statestore.TestStateStore |
|   | hadoop.hdfs.server.federation.statestore.impl.TestStateStoreZK |
|   | hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer |
|   | hadoop.hdfs.server.federation.router.TestRouterJmx |
|   | hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery |
|   | hadoop.tools.TestHdfsConfigFields |
|   | hadoop.hdfs.server.federation.statestore.TestNamenodeRegistration |
|   | hadoop.hdfs.server.federation.router.TestRouterAdmin |
|   | hadoop.hdfs.server.federation.router.TestRouterSafemode |
|   | hadoop.hdfs.server.federation.statestore.impl.TestStateStoreFileSystem |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:85209cc |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12815804/HDFS-10467.PoC.001.patch
|
| JIRA Issue | HDFS-10467 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  findbugs
 checkstyle  xml  shellcheck  shelldocs  cc  |
| uname | Linux e6d858bd83ea 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12
UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 4009fa3 |
| Default Java | 1.8.0_91 |
| shellcheck | v0.4.4 |
| findbugs | v3.0.0 |
| javac | https://builds.apache.org/job/PreCommit-HDFS-Build/15964/artifact/patchprocess/diff-compile-javac-root.txt
|
| checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/15964/artifact/patchprocess/diff-checkstyle-root.txt
|
| shellcheck | https://builds.apache.org/job/PreCommit-HDFS-Build/15964/artifact/patchprocess/diff-patch-shellcheck.txt
|
| whitespace | https://builds.apache.org/job/PreCommit-HDFS-Build/15964/artifact/patchprocess/whitespace-tabs.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/15964/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
|
| javadoc | https://builds.apache.org/job/PreCommit-HDFS-Build/15964/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
|
| unit | https://builds.apache.org/job/PreCommit-HDFS-Build/15964/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/15964/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-HDFS-Build/15964/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/15964/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Router-based HDFS federation
> ----------------------------
>
>                 Key: HDFS-10467
>                 URL: https://issues.apache.org/jira/browse/HDFS-10467
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: fs
>    Affects Versions: 2.7.2
>            Reporter: Inigo Goiri
>         Attachments: HDFS Router Federation.pdf, HDFS-10467.PoC.001.patch, HDFS-10467.PoC.patch,
HDFS-Router-Federation-Prototype.patch
>
>
> Add a Router to provide a federated view of multiple HDFS clusters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message