hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaowei Zhu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10441) libhdfs++: HA namenode support
Date Wed, 13 Jul 2016 22:06:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375865#comment-15375865
] 

Xiaowei Zhu commented on HDFS-10441:
------------------------------------

The latest patch looks almost good to go with one small typo in rpc_engine.cc:
{code}
bool HANamenodeTracker::IsCurrentStandby_locked(const ::asio::ip::tcp::endpoint &ep) const
{
  for(unsigned int i=0;i<active_info_.endpoints.size();i++) {
    if(ep.address() == standby_info_.endpoints[i].address()) {
      if(ep.port() != standby_info_.endpoints[i].port())
        LOG_WARN(kRPC, << "Port mismatch: " << ep << " vs " << standby_info_.endpoints[i]
<< " trying anyway..");
      return true;
    }
  }
  return false;
}
{code}
In the for loop, it should be standby_info_ instead of active_info_. 

Another small indent problem in the same file:
{code}
  if (failedConnection == conn_) {
        LOG_INFO(kRPC, << "Disconnecting from failed RpcConnection");
        conn_.reset();
  }
{code}

> libhdfs++: HA namenode support
> ------------------------------
>
>                 Key: HDFS-10441
>                 URL: https://issues.apache.org/jira/browse/HDFS-10441
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: James Clampffer
>            Assignee: James Clampffer
>         Attachments: HDFS-10441.HDFS-8707.000.patch, HDFS-10441.HDFS-8707.002.patch,
HDFS-10441.HDFS-8707.003.patch, HDFS-10441.HDFS-8707.004.patch, HDFS-10441.HDFS-8707.005.patch,
HDFS-10441.HDFS-8707.006.patch, HDFS-10441.HDFS-8707.007.patch, HDFS-10441.HDFS-8707.008.patch,
HDFS-10441.HDFS-8707.009.patch, HDFS-10441.HDFS-8707.010.patch, HDFS-10441.HDFS-8707.011.patch,
HDFS-10441.HDFS-8707.012.patch, HDFS-8707.HDFS-10441.001.patch
>
>
> If a cluster is HA enabled then do proper failover.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message