hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Hansen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9271) Implement basic NN operations
Date Mon, 11 Jul 2016 16:14:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371081#comment-15371081
] 

Bob Hansen commented on HDFS-9271:
----------------------------------

Thanks for all that hard work, [~anatoli.shein].

A few comments:
* In GetBlockLocations(hdfspp.h, filesystem.cc), use offset_t or uint64_t rather than long.
 It's less ambiguous.
* In getAbsolutePath (hdfs.cc), how about returning optional(string) rather than an empty
string on error.  It makes the error state explicit and explicitly checked.
* Make a new bug to capture supporting ".." semantics
* It appears the majority of hdfs_ext_test.c has been commented out.  What this intentional,
or debugging dirt that slipped in?
* Can we add a test for relative paths for all the functions where we added them in?
* Can we implement hdfsMove and/or hdfsTruncateFile with just metadata operations?
* Move to libhdfspp implementations in hdfs_shim for GetDefaultBlocksize[AtPath]
* Implement hdfsUnbufferFile as a no-op?
* Do we support single-dot relative paths?  e.g. can I call hdfsGetPathInfo(fs, ".")?  Do
we have tests over that?
* Do we have tests that show that libhdfspp's getReadStatistics match libhdfs's getReadStatistics?

Minor little nits:
* For the absolute path, I personally prefer abs_path = getAbsolutPath(...) rather than abs_path(getAbsolutePath).
 They both compile to the same thing (see https://en.wikipedia.org/wiki/Return_value_optimization);
I think the whitespace with the assignment makes the _what_ and the _content_ separation cleaner
* Refactor CheckSystemAndHandle to use CheckHandle (https://en.wikipedia.org/wiki/Don't_repeat_yourself)



> Implement basic NN operations
> -----------------------------
>
>                 Key: HDFS-9271
>                 URL: https://issues.apache.org/jira/browse/HDFS-9271
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Bob Hansen
>            Assignee: Anatoli Shein
>         Attachments: HDFS-9271.HDFS-8707.000.patch, HDFS-9271.HDFS-8707.001.patch, HDFS-9271.HDFS-8707.002.patch
>
>
> Expose via C and C++ API:
> * mkdirs
> * rename
> * delete
> * stat
> * chmod
> * chown
> * getListing
> * setOwner



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message