hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8780) Fetching live/dead datanode list with arg true for removeDecommissionNode,returns list with decom node.
Date Fri, 29 Jul 2016 18:30:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399821#comment-15399821
] 

Konstantin Shvachko commented on HDFS-8780:
-------------------------------------------

Would be good to port this to branch-2.7.

> Fetching live/dead datanode list with arg true for removeDecommissionNode,returns list
with decom node.
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8780
>                 URL: https://issues.apache.org/jira/browse/HDFS-8780
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: J.Andreina
>            Assignee: J.Andreina
>             Fix For: 2.8.0
>
>         Attachments: HDFS-8780.1.patch, HDFS-8780.2.patch, HDFS-8780.3.patch
>
>
> Current implementation: 
> ======================
> DatanodeManager#removeDecomNodeFromList() , Decommissioned node will be removed from
dead/live node list only if below conditions are met
>  I . If the Include list is not empty. 
>  II. If include and exclude list does not have decommissioned node and node state is
decommissioned. 
> {code}
>       if (!hostFileManager.hasIncludes()) {
>               return;
>        }
>       if ((!hostFileManager.isIncluded(node)) && (!hostFileManager.isExcluded(node))
>           && node.isDecommissioned()) {
>         // Include list is not empty, an existing datanode does not appear
>         // in both include or exclude lists and it has been decommissioned.
>         // Remove it from the node list.
>         it.remove();
>       }
> {code}
> As mentioned in javadoc a datanode cannot be in "already decommissioned datanode state".
> Following the steps mentioned in javadoc datanode state is "dead" and not decommissioned.
> *Can we avoid the unnecessary checks and have check for the node is in decommissioned
state then remove from node list. ?*
> Please provide your feedback.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message