Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 21 Jun 2016 22:39:58 +0000 (UTC)
From: "Lei (Eddy) Xu (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12981097.1466458539000.18188.1466548798295@Atlassian.JIRA>
In-Reply-To: <JIRA.12981097.1466458539000@Atlassian.JIRA>
References: <JIRA.12981097.1466458539000@Atlassian.JIRA> <JIRA.12981097.1466458539000@arcas>
Subject: [jira] [Commented] (HDFS-10551)
 o.a.h.h.s.diskbalancer.command.Command does not actually verify options as
 expected.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 21 Jun 2016 22:40:00 -0000


    [ https://issues.apache.org/jira/browse/HDFS-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342936#comment-15342936 ] 

Lei (Eddy) Xu commented on HDFS-10551:
--------------------------------------

Ok, please do so.

> o.a.h.h.s.diskbalancer.command.Command does not actually verify options as expected.
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-10551
>                 URL: https://issues.apache.org/jira/browse/HDFS-10551
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>            Reporter: Lei (Eddy) Xu
>            Assignee: Anu Engineer
>            Priority: Critical
>         Attachments: HDFS-10551-HDFS-1312.001.patch
>
>
> In {{diskbalancer.command.Command#verifyCommandOptions}}. The following code does not do what it expected to do:
> {code}
> if (!validArgs.containsKey(opt.getArgName())) {
> {code}
> opt.getArgName() always returns "arg" instead of i.e., {{report}} or {{uri}}, which is the expected parameter to check.
> It should use {{opt.getLongOpt()}} to get the option names. It can pass on the branch because {{opt.getArgName()}} always returns {{"arg"}}, which is accidently in {{validArgs}}. However I don't think it is the intention for this function.
> Additionally, in the following code
> {code}
> validArguments.append("Valid arguments are : %n");
> {code}
> This {{%n}} is not used.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org