Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 616B3200B4D for ; Fri, 17 Jun 2016 22:12:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6011D160A4C; Fri, 17 Jun 2016 20:12:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D7CC6160A63 for ; Fri, 17 Jun 2016 22:12:06 +0200 (CEST) Received: (qmail 42578 invoked by uid 500); 17 Jun 2016 20:12:05 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 42473 invoked by uid 99); 17 Jun 2016 20:12:05 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jun 2016 20:12:05 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 889022C1F60 for ; Fri, 17 Jun 2016 20:12:05 +0000 (UTC) Date: Fri, 17 Jun 2016 20:12:05 +0000 (UTC) From: "Bob Hansen (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10511) libhdfs++: make error returning mechanism consistent across all hdfs operations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 17 Jun 2016 20:12:07 -0000 [ https://issues.apache.org/jira/browse/HDFS-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336837#comment-15336837 ] Bob Hansen commented on HDFS-10511: ----------------------------------- hadoop-hdfs-native-client/src/main/native/libhdfs/include/hdfs/hdfs.h is part of libhdfs, and we're fairly committed to not changing it. The existing text of "nonzero error code otherwise" is sufficient to cover the behavior of returning -1 on error. The functions in hdfs_ext.h are fair game, and your updated comments are well-received. > libhdfs++: make error returning mechanism consistent across all hdfs operations > ------------------------------------------------------------------------------- > > Key: HDFS-10511 > URL: https://issues.apache.org/jira/browse/HDFS-10511 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client > Reporter: Anatoli Shein > Assignee: Anatoli Shein > Attachments: HDFS-10511.HDFS-8707.000.patch, HDFS-10511.HDFS-8707.000.patch, HDFS-10511.HDFS-8707.001.patch, HDFS-10511.HDFS-8707.002.patch > > > Errno should always be set. > If function is returning a code on stack, it should be consistent with errno. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org