Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2589F200B17 for ; Tue, 7 Jun 2016 00:31:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 24249160A24; Mon, 6 Jun 2016 22:31:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6E10D160A55 for ; Tue, 7 Jun 2016 00:31:22 +0200 (CEST) Received: (qmail 9213 invoked by uid 500); 6 Jun 2016 22:31:21 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 8823 invoked by uid 99); 6 Jun 2016 22:31:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jun 2016 22:31:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 3D5D52C1F64 for ; Mon, 6 Jun 2016 22:31:21 +0000 (UTC) Date: Mon, 6 Jun 2016 22:31:21 +0000 (UTC) From: "Jiayi Zhou (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HDFS-10375) Remove redundant TestMiniDFSCluster.testDualClusters MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 06 Jun 2016 22:31:23 -0000 [ https://issues.apache.org/jira/browse/HDFS-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317410#comment-15317410 ] Jiayi Zhou edited comment on HDFS-10375 at 6/6/16 10:31 PM: ------------------------------------------------------------ I've merged them into 1 commit now. How about this new patch 003? was (Author: clouderajiayi): HI've merged them into 1 commit now. How about this new patch 003? > Remove redundant TestMiniDFSCluster.testDualClusters > ---------------------------------------------------- > > Key: HDFS-10375 > URL: https://issues.apache.org/jira/browse/HDFS-10375 > Project: Hadoop HDFS > Issue Type: Test > Components: test > Affects Versions: 2.6.0 > Reporter: John Zhuge > Assignee: Jiayi Zhou > Priority: Trivial > Labels: newbie > Attachments: HDFS-10375.002.patch, HDFS-10375.003.patch > > > Unit test {{TestMiniDFSCluster.testDualClusters}} is redundant because {{testClusterWithoutSystemProperties}} already proves {{cluster.getDataDirectory() == getProp(HDFS_MINIDFS_BASEDIR) + "/data"}}. This unit test sets HDFS_MINIDFS_BASEDIR to 2 different values and brings up 2 clusters, of course they will have different data directory. > Remove it to save the time to bring up 2 mini clusters. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org