Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 27 Jun 2016 17:37:52 +0000 (UTC)
From: "Gary Helmling (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12938973.1455323508000.7003.1467049072060@Atlassian.JIRA>
In-Reply-To: <JIRA.12938973.1455323508000@Atlassian.JIRA>
References: <JIRA.12938973.1455323508000@Atlassian.JIRA> <JIRA.12938973.1455323508621@arcas>
Subject: [jira] [Updated] (HDFS-9805) TCP_NODELAY not set before SASL
 handshake in data transfer pipeline
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 27 Jun 2016 17:37:54 -0000


     [ https://issues.apache.org/jira/browse/HDFS-9805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Helmling updated HDFS-9805:
--------------------------------
    Attachment: HDFS-9805.004.patch

Updated patch adding:

* a new configuration property (dfs.data.transfer.server.tcpnodelay), defaulting to true, controlling the TCP_NODELAY setting in the DN -> DN transfer path
* a test case check the TCP_NODELAY was enabled on all used sockets when the relevant config settings are enabled

Note that I had to modify {{DataNode#newSocket()}} in this patch in order to support the test case.  Prior to this, {{newSocket()}} was not using the configured socket factory, instead creating sockets directly.  This seems like a change we would want anyway, just calling in out.

> TCP_NODELAY not set before SASL handshake in data transfer pipeline
> -------------------------------------------------------------------
>
>                 Key: HDFS-9805
>                 URL: https://issues.apache.org/jira/browse/HDFS-9805
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>         Attachments: HDFS-9805.002.patch, HDFS-9805.003.patch, HDFS-9805.004.patch
>
>
> There are a few places in the DN -> DN block transfer pipeline where TCP_NODELAY is not set before doing a SASL handshake:
> * in {{DataNode.DataTransfer::run()}}
> * in {{DataXceiver::replaceBlock()}}
> * in {{DataXceiver::writeBlock()}}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org