hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10580) DiskBalancer : Make use of unused methods in GreedyPlanner to print debug info
Date Wed, 29 Jun 2016 06:17:45 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15354630#comment-15354630
] 

Anu Engineer commented on HDFS-10580:
-------------------------------------

+1, (Non-binding). Thank you for contributing this patch. I really appreciate you taking time
out to tune the output and look at the how noisy the logging can be. Since this is used only
in the planning phase these log statements will not be part of any logs. So I guess it is
okay to be little verbose if debug flag is specified.


> DiskBalancer : Make use of unused methods in GreedyPlanner to print debug info
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-10580
>                 URL: https://issues.apache.org/jira/browse/HDFS-10580
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: balancer & mover
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>            Priority: Minor
>         Attachments: HDFS-10580.001.patch, HDFS-10580.002.patch
>
>
> There are two unused method {{skipVolume}} and {{printQueue}} in class {{GreedyPlanner}}.
These two methods were added in HDFS-9469 but they are not used. In these two method, it will
print the detail debug info. So We can make use of them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message