hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lei (Eddy) Xu (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-10551) o.a.h.h.s.diskbalancer.command.Command does not actually verify options as expected.
Date Tue, 21 Jun 2016 22:20:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342880#comment-15342880
] 

Lei (Eddy) Xu edited comment on HDFS-10551 at 6/21/16 10:20 PM:
----------------------------------------------------------------

Hi, [~anu]

It seems that TestDiskBalancerCommand fails on jenkins here.


was (Author: eddyxu):
Hi, [~anu]

It seems that TestDiskBalancerCommand fails on trunk here.

> o.a.h.h.s.diskbalancer.command.Command does not actually verify options as expected.
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-10551
>                 URL: https://issues.apache.org/jira/browse/HDFS-10551
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>            Reporter: Lei (Eddy) Xu
>            Assignee: Anu Engineer
>            Priority: Critical
>         Attachments: HDFS-10551-HDFS-1312.001.patch
>
>
> In {{diskbalancer.command.Command#verifyCommandOptions}}. The following code does not
do what it expected to do:
> {code}
> if (!validArgs.containsKey(opt.getArgName())) {
> {code}
> opt.getArgName() always returns "arg" instead of i.e., {{report}} or {{uri}}, which is
the expected parameter to check.
> It should use {{opt.getLongOpt()}} to get the option names. It can pass on the branch
because {{opt.getArgName()}} always returns {{"arg"}}, which is accidently in {{validArgs}}.
However I don't think it is the intention for this function.
> Additionally, in the following code
> {code}
> validArguments.append("Valid arguments are : %n");
> {code}
> This {{%n}} is not used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message