hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-10544) Balancer doesn't work with IPFailoverProxyProvider
Date Fri, 17 Jun 2016 21:54:05 GMT

     [ https://issues.apache.org/jira/browse/HDFS-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Zhe Zhang updated HDFS-10544:
-----------------------------
    Attachment: HDFS-10544.01.patch

v0 patch didn't work because {{HAUtil#useLogicalUri}} expects an URI rather than String (btw
sorry I missed the build failure before uploading patch). I don't think this is a good API
design, because nameservice ID can be an arbitrary string. 

But to avoid changing public API {{HAUtil#useLogicalUri}}, in v1 patch I added another API
to get the boolean condition from string. Also using the static method to check, rather than
creating an instance of the proxy provider.

> Balancer doesn't work with IPFailoverProxyProvider
> --------------------------------------------------
>
>                 Key: HDFS-10544
>                 URL: https://issues.apache.org/jira/browse/HDFS-10544
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>         Attachments: HDFS-10544.00.patch, HDFS-10544.01.patch
>
>
> Right now {{Balancer}} gets the NN URIs through {{DFSUtil#getNameServiceUris}}, which
returns logical URIs in HA is enabled. If {{IPFailoverProxyProvider}} is used, {{Balancer}}
will not be able to start.
> I think the bug is at {{DFSUtil#getNameServiceUris}}:
> {code}
>     for (String nsId : getNameServiceIds(conf)) {
>       if (HAUtil.isHAEnabled(conf, nsId)) {
>         // Add the logical URI of the nameservice.
>         try {
>           ret.add(new URI(HdfsConstants.HDFS_URI_SCHEME + "://" + nsId));
> {code}
> Then {{if}} clause should also consider if the {{FailoverProxyProvider}} has {{useLogicalURI}}
enabled. If not, {{getNameServiceUris}} should try to resolve the physical URI for this nsId.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message