hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Hansen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10511) libhdfs++: make error returning mechanism consistent across all hdfs operations
Date Fri, 17 Jun 2016 20:12:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336837#comment-15336837
] 

Bob Hansen commented on HDFS-10511:
-----------------------------------

hadoop-hdfs-native-client/src/main/native/libhdfs/include/hdfs/hdfs.h is part of libhdfs,
and we're fairly committed to not changing it.

The existing text of "nonzero error code otherwise" is sufficient to cover the behavior of
returning -1 on error.

The functions in hdfs_ext.h are fair game, and your updated comments are well-received.



> libhdfs++: make error returning mechanism consistent across all hdfs operations
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-10511
>                 URL: https://issues.apache.org/jira/browse/HDFS-10511
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Anatoli Shein
>            Assignee: Anatoli Shein
>         Attachments: HDFS-10511.HDFS-8707.000.patch, HDFS-10511.HDFS-8707.000.patch,
HDFS-10511.HDFS-8707.001.patch, HDFS-10511.HDFS-8707.002.patch
>
>
> Errno should always be set.
> If function is returning a code on stack, it should be consistent with errno.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message