hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10501) DiskBalancer: Use the default datanode port if port is not provided.
Date Wed, 08 Jun 2016 17:45:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15321039#comment-15321039
] 

Arpit Agarwal commented on HDFS-10501:
--------------------------------------

The patch lgtm.

{{createDatanodeProxy}} appears to accept leading/trailing spaces since {{NetUtils#createSocketAddr}}
trims the input string. A potential improvement is trimming nodeName before doing the regex
match for consistency.

> DiskBalancer: Use the default datanode port if port is not provided.
> --------------------------------------------------------------------
>
>                 Key: HDFS-10501
>                 URL: https://issues.apache.org/jira/browse/HDFS-10501
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: balancer & mover
>    Affects Versions: HDFS-1312
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>             Fix For: HDFS-1312
>
>         Attachments: HDFS-10501-HDFS-1312.001.patch
>
>
> In the query command, we should read the default datanode port from the config if the
user does provides hostname instead of hostname:port



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message