hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10458) getFileEncryptionInfo should return quickly for non-encrypted cluster
Date Fri, 03 Jun 2016 22:29:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314998#comment-15314998
] 

Hadoop QA commented on HDFS-10458:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red} 11m 12s {color} | {color:red}
Docker failed to build yetus/hadoop:2c91fd8. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12808073/HDFS-10458.03.patch
|
| JIRA Issue | HDFS-10458 |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/15648/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> getFileEncryptionInfo should return quickly for non-encrypted cluster
> ---------------------------------------------------------------------
>
>                 Key: HDFS-10458
>                 URL: https://issues.apache.org/jira/browse/HDFS-10458
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: encryption, namenode
>    Affects Versions: 2.6.0
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>         Attachments: HDFS-10458.00.patch, HDFS-10458.03.patch, HDFSA-10458.01.patch,
HDFSA-10458.02.patch
>
>
> {{FSDirectory#getFileEncryptionInfo}} always acquires {{readLock}} and checks if the
path belongs to an EZ. For a busy system with potentially many listing operations, this could
cause locking contention.
> I think we should add a call {{EncryptionZoneManager#hasEncryptionZone()}} to return
whether the system has any EZ. If no EZ at all, {{getFileEncryptionInfo}} should return null
without {{readLock}}.
> If {{hasEncryptionZone}} is only used in the above scenario, maybe itself doesn't need
a {{readLock}} -- if the system doesn't have any EZ when {{getFileEncryptionInfo}} is called
on a path, it means the path cannot be encrypted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message