hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9353) Code and comment mismatch in JavaKeyStoreProvider
Date Mon, 06 Jun 2016 23:44:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317502#comment-15317502
] 

Daniel Templeton commented on HDFS-9353:
----------------------------------------

I'm OK with just deleting the comment.

> Code and comment mismatch in  JavaKeyStoreProvider 
> ---------------------------------------------------
>
>                 Key: HDFS-9353
>                 URL: https://issues.apache.org/jira/browse/HDFS-9353
>             Project: Hadoop HDFS
>          Issue Type: Task
>            Reporter: nijel
>            Assignee: Andras Bokor
>            Priority: Trivial
>
> In
> org.apache.hadoop.crypto.key.JavaKeyStoreProvider.JavaKeyStoreProvider(URI uri, Configuration
conf) throws IOException
> The comment mentioned is
> {code}
> // Get the password file from the conf, if not present from the user's
> // environment var
> {code}
> But the code takes the value form ENV first
> I think this make sense since the user can pass the ENV for a particular run.
> My suggestion is to change the comment



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message