Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D07A6200AC0 for ; Mon, 9 May 2016 15:23:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CF7A31601D4; Mon, 9 May 2016 13:23:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 24BA316098A for ; Mon, 9 May 2016 15:23:13 +0200 (CEST) Received: (qmail 77162 invoked by uid 500); 9 May 2016 13:23:13 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 77088 invoked by uid 99); 9 May 2016 13:23:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 May 2016 13:23:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E75B22C1F64 for ; Mon, 9 May 2016 13:23:12 +0000 (UTC) Date: Mon, 9 May 2016 13:23:12 +0000 (UTC) From: "Kihwal Lee (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10372) Fix for failing TestFsDatasetImpl#testCleanShutdownOfVolume MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 09 May 2016 13:23:15 -0000 [ https://issues.apache.org/jira/browse/HDFS-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276350#comment-15276350 ] Kihwal Lee commented on HDFS-10372: ----------------------------------- [~shahrs87], it's up to you to decide whether to improve it as [~iwasakims] suggested. > Fix for failing TestFsDatasetImpl#testCleanShutdownOfVolume > ----------------------------------------------------------- > > Key: HDFS-10372 > URL: https://issues.apache.org/jira/browse/HDFS-10372 > Project: Hadoop HDFS > Issue Type: Bug > Components: test > Affects Versions: 2.7.3 > Reporter: Rushabh S Shah > Assignee: Rushabh S Shah > Attachments: HDFS-10372.patch > > > TestFsDatasetImpl#testCleanShutdownOfVolume fails very often. > We added more debug information in HDFS-10260 to find out why this test is failing. > Now I think I know the root cause of failure. > I thought that {{LocatedBlock#getLocations()}} returns an array of DatanodeInfo but now I realized that it returns an array of DatandeStorageInfo (which is subclass of DatanodeInfo). > In the test I intended to check whether the exception contains the xfer address of the DatanodeInfo. Since {{DatanodeInfo#toString()}} method returns the xfer address, I checked whether exception contains {{DatanodeInfo#toString}} or not. > But since {{LocatedBlock#getLocations()}} returned an array of DatanodeStorageInfo, it has storage info in the toString() implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org