Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D0A01200AC0 for ; Mon, 9 May 2016 23:03:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CF2FB16099C; Mon, 9 May 2016 21:03:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2F7361609A8 for ; Mon, 9 May 2016 23:03:14 +0200 (CEST) Received: (qmail 41886 invoked by uid 500); 9 May 2016 21:03:13 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 41775 invoked by uid 99); 9 May 2016 21:03:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 May 2016 21:03:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id EA0792C1F6A for ; Mon, 9 May 2016 21:03:12 +0000 (UTC) Date: Mon, 9 May 2016 21:03:12 +0000 (UTC) From: "Tsz Wo Nicholas Sze (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-10346) Implement asynchronous setPermission/setOwner for DistributedFileSystem MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 09 May 2016 21:03:15 -0000 [ https://issues.apache.org/jira/browse/HDFS-10346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277031#comment-15277031 ] Tsz Wo Nicholas Sze commented on HDFS-10346: -------------------------------------------- Thanks Xiaobing! Some comment ont he patch. - In AsyncDistributedFileSystem, -* Need to call fixRelativePart. -* javadoc should describe return value. - testPermissionChecking should first create all files/directories synchronously, and then call setPermission/setOwner asynchronously in a separated loop. - Indeed, testAggressiveConcurrentAsyncAPI is a better test. Why don't we just keep it and remove testPermissionChecking? - I suggest to add one more test to mix up rename/setPermission/setOwner together. > Implement asynchronous setPermission/setOwner for DistributedFileSystem > ----------------------------------------------------------------------- > > Key: HDFS-10346 > URL: https://issues.apache.org/jira/browse/HDFS-10346 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs, hdfs-client > Reporter: Xiaobing Zhou > Assignee: Xiaobing Zhou > Attachments: HDFS-10346-HDFS-9924.000.patch, HDFS-10346-HDFS-9924.001.patch, HDFS-10346-HDFS-9924.003.patch > > > This is proposed to implement an asynchronous setPermission and setOwner. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org