hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raymie Stata (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10442) S3A file-create should throw error rather than overwrite directories
Date Fri, 20 May 2016 17:54:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293845#comment-15293845
] 

Raymie Stata commented on HDFS-10442:
-------------------------------------

[~stevel@apache.org] found the following test-cases being skipped that probably shouldn't
be:
{noformat}
2016-05-20 11:03:07,144 INFO  contract.AbstractFSContractTestBase (AbstractFSContractTestBase.java:describe(240))
- verify trying to create a file over a non-empty dir fails
2016-05-20 11:03:10,615 INFO  contract.ContractTestUtils (ContractTestUtils.java:skip(425))
- Skipping: Object store allows a file to overwrite a directory

2016-05-20 11:03:14,992 INFO  contract.AbstractFSContractTestBase (AbstractFSContractTestBase.java:setup(172))
- Test filesystem = s3a://hwdev-steve implemented by S3AFileSystem{uri=s3a://hwdev-steve,
workingDir=s3a://hwdev-steve/user/stevel, partSize=104857600, enableMultiObjectsDelete=true,
maxKeys=5000, readAhead=65536, blockSize=33554432, multiPartThreshold=2147483647, statistics
{0 bytes read, 266 bytes written, 25 read ops, 0 large read ops, 11 write ops}, metrics {{Context=S3AFileSystem}
{FileSystemId=0b9a969b-9c2e-48da-9bce-4599ae8a2cb9-hwdev-steve} {fsURI=s3a://hwdev-steve/}
{files_created=3} {files_copied=0} {files_copied_bytes=0} {files_deleted=3} {directories_created=3}
{directories_deleted=0} {ignored_errors=3} {streamReadOperations=0} {streamForwardSeekOperations=0}
{streamBytesRead=0} {streamSeekOperations=0} {streamReadExceptions=0} {streamOpened=0} {streamReadOperationsIncomplete=0}
{streamAborted=0} {streamReadFullyOperations=0} {streamClosed=0} {streamBytesSkippedOnSeek=0}
{streamCloseOperations=0} {streamBytesBackwardsOnSeek=0} {streamBackwardSeekOperations=0}
}}
2016-05-20 11:03:16,381 INFO  contract.ContractTestUtils (ContractTestUtils.java:skip(425))
- Skipping: blobstores can't distinguish empty directories from files
{noformat}

> S3A file-create should throw error rather than overwrite directories
> --------------------------------------------------------------------
>
>                 Key: HDFS-10442
>                 URL: https://issues.apache.org/jira/browse/HDFS-10442
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Raymie Stata
>
> S3A.create(Path,FsPermission,boolean,int,short,long,Progressable) is not checking to
see if it's being asked to overwrite a directory.  It could easily do so, and should throw
an error in this case.
> There is a test-case for this in AbstractFSContractTestBase, but it's being skipped because
S3A is a blobstore.  However, both the Azure and Swift file systems make this test, and the
new S3 one should as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message